跳到内容
新问题

对这个项目有疑问吗?注册一个免费的GitHub帐户以打开一个问题,并联系其维护者和社区。

单击“注册GitHub”,表示您同意我们的服务条款隐私声明。我们偶尔会向您发送与帐户相关的电子邮件。

已经在GitHub上了吗?登录到您的帐户

键盘快捷键:修复设置侧栏切换快捷键 #43428

已合并
将3个提交合并到
2022年9月20日

对话

t-hamano公司
复制链接
贡献者

的一部分#43352

什么?

此PR修复了设置侧栏切换快捷方式。

为什么?

Ctrl+Shift+,(在Windows上)应打开和关闭设置侧栏,如下所示:

键盘-模式

然而,如中所述MDN文档,KeyboardEvent.key返回一个考虑修改键状态的值。

这个键盘事件界面的键只读属性返回用户按下的键的值,同时考虑到Shift等修改键的状态以及键盘区域设置和布局。

因此,在Windows中,,键被检测为<键:

0e4bc36ab35f69edb48f50c9cd154618.mp4

怎么用?

键盘快捷方式模式应该显示不考虑修改键的键标签。
因此,我更换了<具有,在检测条件下isKeyboard事件.
据我所知,<,没有用作其他键盘事件,所以我认为替换它们应该没有任何效果。
此外,此修复程序不会根据操作系统进行判断。如果这在Mac上不是问题,我想排除MacbyisAppleOS().

测试说明

  • 打开帖子/站点编辑器。
  • 选择块,然后按Ctrl+Shift+组合键,(或Mac上的快捷方式)
  • 确认设置侧栏打开和关闭。
22aef74a88f48ef7bc78b4ab48dff550.mp4

@github-操作
复制链接

github-操作 机器人程序 评论2022年8月19日

尺寸变化:-4亿(0%)

总大小:1.26 MB

文件名 尺寸 更改
构建/块库/index.min.js 190千字节 -27亿(0%)
build/keycodes/index.min.js 1.83千字节 +230亿(+1%)
ℹ️查看未更改
文件名 尺寸
构建/a11y/index.min.js 982亿
build/annotations/index.min.js 2.76千字节
构建/api-fetch/index.min.js 2.26千字节
build/autop/index.min.js版本 2.14千字节
build/blob/index.min.js 475亿
build/block-directory/index.min.js 7.05千字节
构建/块目录/样式-rtl.css 990亿
构建/块目录/样式.css 991亿
构建/块编辑器/默认编辑器样式-rtl.css 378亿
构建/块编辑器/默认编辑器样式.css 378亿
build/block-editor/index.min.js 163千字节
build/block-editor/style-rtl.css 15.4千字节
构建/块编辑器/style.css 15.4千字节
build/block-library/blocks/archives/editor-rtl.css 61亿
build/block-library/blocks/archives/editor.css 60亿
build/block-library/blocks/archives/style-rtl.css 65亿
build/block-library/blocks/archives/style.css 65亿
build/block-library/blocks/audio/editor-rtl.css 150亿
build/block-library/blocks/audio/editor.css 150亿
build/block-library/blocks/audio/style-rtl.css 122亿
build/block-library/blocks/audio/style.css 122亿
构建/block-library/blocks/audio/theme-rtl.css 126亿
构建/block-library/blocks/audio/theme.css 126亿
build/block-library/blocks/avatar/editor-rtl.css 116亿
build/block-library/blocks/avatar/editor.css 116亿
build/block-library/blocks/avatar/style-rtl.css 84亿
build/block-library/blocks/avatar/style.css 84亿
build/block-library/blocks/block/editor-rtl.css 161亿
build/block-library/blocks/block/editor.css 161亿
build/block-library/blocks/button/editor-rtl.css 482亿
build/block-library/blocks/button/editor.css 482亿
build/block-library/blocks/button/style-rtl.css 523亿
build/block-library/blocks/button/style.css 523亿
build/block-library/blocks/buttons/editor-rtl.css 337亿
build/block-library/blocks/buttons/editor.css 337亿
build/block-library/blocks/buttons/style-rtl.css 332亿
build/block-library/blocks/buttons/style.css 332亿
构建/块库/blocks/calendar/style-rtl.css 207亿
build/block-library/blocks/calendar/style.css 207亿
build/block-library/blocks/categories/editor-rtl.css 84亿
build/block-library/blocks/categories/editor.css 83亿
build/block-library/blocks/categories/style-rtl.css 100亿
build/block-library/blocks/categories/style.css 100亿
build/block-library/blocks/code/editor-rtl.css 53亿
build/block-library/blocks/code/editor.css 53亿
build/block-library/blocks/code/style-rtl.css 103亿
build/block-library/blocks/code/style.css 103亿
build/block-library/blocks/code/theme-rtl.css 124亿
构建/block-library/blocks/code/theme.css 124亿
build/block-library/blocks/columns/editor-rtl.css 108亿
build/block-library/blocks/columns/editor.css 108亿
build/block-library/blocks/columns/style-rtl.css 406磅
build/block-library/blocks/columns/style.css 406亿
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125亿
build/block-library/blocks/comment-author-avatar/editor.css 125亿
build/block-library/blocks/comment-content/style-rtl.css 92亿
build/block-library/blocks/comment-content/style.css 92亿
build/block-library/blocks/comment-template/style-rtl.css 187亿
build/block-library/blocks/comment-template/style.css 185亿
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123亿
构建/块库/块/注释页码/editor.css 121亿
build/block-library/blocks/comments-pagination/editor-rtl.css 222亿
build/block-library/blocks/comments-pageination/editor.css 209亿
build/block-library/blocks/comments-pagination/style-rtl.css 235亿
build/block-library/blocks/comments-pageination/style.css 231亿
构建/块库/blocks/comments标题/editor-rtl.css 75亿
build/block-library/blocks/comments-title/editor.css 75亿
build/block-library/blocks/comments/editor-rtl.css 834磅
build/block-library/blocks/comments/editor.css 832亿
build/block-library/blocks/comments/style-rtl.css 632亿
build/block-library/blocks/comments/style.css 630亿
build/block-library/blocks/cover/editor-rtl.css 605亿
build/block-library/blocks/cover/editor.css 607磅
构建/block-library/blocks/cover/style-rtl.css 1.57千字节
build/block-library/blocks/cover/style.css 1.55千字节
build/block-library/blocks/embed/editor-rtl.css 293亿
build/block-library/blocks/embed/editor.css 293亿
build/block-library/blocks/embed/style-rtl.css 410亿
build/block-library/blocks/embed/style.css 410亿
build/block-library/blocks/embed/theme-rtl.css 126亿
build/block-library/blocks/embed/theme.css 126亿
build/block-library/blocks/file/editor-rtl.css 300亿
build/block-library/blocks/file/editor.css 300亿
build/block-library/blocks/file/style-rtl.css 253亿
build/block-library/blocks/file/style.css 254亿
build/block-library/blocks/file/view.min.js 346亿
build/block-library/blocks/freeform/editor-rtl.css 2.44千字节
build/block-library/blocks/freeform/editor.css 2.44千字节
构建/block-library/blocks/gallery/editor-rtl.css 948亿
build/block-library/blocks/galletry/editor.css 950亿
build/block-library/blocks/gallower/style-rtl.css 1.53千字节
build/block-library/blocks/gallower/style.css 1.53千字节
build/block-library/blocks/gallower/theme-rtl.css版本 108亿
build/block-library/blocks/gallery/主题.css 108亿
build/block-library/blocks/group/editor-rtl.css 337亿
build/block-library/blocks/group/editor.css 337亿
build/block-library/blocks/group/style-rtl.css 57亿
build/block-library/blocks/group/style.css 57亿
构建/block-library/blocks/group/theme-rtl.css 78亿
构建/块-库/块/组/主题.css 78亿
构建/block-library/blocks/heading/style-rtl.css 76亿
build/block-library/blocks/heading/style.css 76亿
build/block-library/blocks/html/editor-rtl.css 327亿
build/block-library/blocks/html/editor.css 329亿
build/block-library/blocks/image/editor-rtl.css 876亿
build/block-library/blocks/image/editor.css 873亿
build/block-library/blocks/image/style-rtl.css 627亿
build/block-library/blocks/image/style.css 630亿
构建/block-library/blocks/image/theme-rtl.css 126亿
构建/block-library/blocks/image/theme.css 126亿
build/block-library/blocks/latest-comments/style-rtl.css 284磅
build/block-library/blocks/latest-comments/style.css 284亿
build/block-library/blocks/platest-posts/editor-rtl.css 213亿
build/block-library/blocks/platest-posts/editor.css 212亿
构建/block-library/blocks/latest posts/style-rtl.css 463亿
build/block-library/blocks/platest-posts/style.css 462亿
build/block-library/blocks/list/style-rtl.css 88亿
build/block-library/blocks/list/style.css 88亿
build/block-library/blocks/media-text/editor-rtl.css 266亿
build/block-library/blocks/media-text/editor.css 263亿
build/block-library/blocks/media-text/style-rtl.css 507亿
build/block-library/blocks/media-text/style.css 505亿
build/block-library/blocks/more/editor-rtl.css 431亿
build/block-library/blocks/more/editor.css 431亿
build/block-library/blocks/navigation-link/editor-rtl.css 705亿
build/block-library/blocks/navigation-link/editor.css 703亿
build/block-library/blocks/navigation-link/style-rtl.css 115亿
构建/块库/块/导航链接/style.css 115亿
build/block-library/blocks/navigation-submenu/editor-rtl.css 296亿
build/block-library/blocks/navigation-submenu/editor.css 295亿
build/block-library/blocks/navigation-submenu/view.min.js 423亿
build/block-library/blocks/navigation/editor-rtl.css 1.99千字节
build/block-library/blocks/navigation/editor.css 2千字节
build/block-library/blocks/navigation/style-rtl.css 2.17千字节
build/block-library/blocks/navigation/style.css 2.16千字节
build/block-library/blocks/navigation/view-modal.min.js 2.78千字节
build/block-library/blocks/navigation/view.min.js 443亿
build/block-library/blocks/nextpage/editor-rtl.css 395亿
build/block-library/blocks/nextpage/editor.css 395亿
build/block-library/blocks/page-list/editor-rtl.css 363亿
build/block-library/blocks/page-list/editor.css 363亿
build/block-library/blocks/page-list/style-rtl.css 175亿
build/block-library/blocks/page-list/style.css 175亿
build/block-library/blocks/pragment/editor-rtl.css 174亿
build/block-library/blocks/pragment/editor.css 174亿
build/block-library/blocks/pragment/style-rtl.css 260亿
构建/块库/blocks/paragraph/style.css 260亿
build/block-library/blocks/post-author/style-rtl.css 175亿
build/block-library/blocks/post-author/style.css 176亿
build/block-library/blocks/post-comments-form/editor-rtl.css 96亿
build/block-library/blocks/post-comments-form/editor.css 96亿
build/block-library/blocks/post-comments-form/style-rtl.css 493亿
build/block-library/blocks/post-comments-form/style.css 493亿
构建/块库/blocks/post-date/style-rtl.css 61亿
build/block-library/blocks/post-date/style.css 61亿
build/block-library/blocks/post-extract/editor-rtl.css 73亿
build/block-library/blocks/post-extract/editor.css 73亿
build/block-library/blocks/post-extract/style-rtl.css 69亿
build/block-library/blocks/post-extract/style.css 69亿
build/block-library/blocks/post-featured-image/editor-rtl.css 547亿
build/block-library/blocks/post-featured-image/editor.css 545亿
build/block-library/blocks/post-featured-image/style-rtl.css 315亿
build/block-library/blocks/post-featured-image/style.css 315亿
build/block-library/blocks/post-navigation-link/style-rtl.css 153亿
构建/块库/blocks/post导航链接/style.css 153亿
build/block-library/blocks/post-template/editor-rtl.css 99亿
build/block-library/blocks/post-template/editor.css 98亿
build/block-library/blocks/post-template/style-rtl.css 282亿
构建/块库/blocks/post-template/style.css 282亿
build/block-library/blocks/post-terms/style-rtl.css 73亿
build/block-library/blocks/post-terms/style.css 73亿
build/block-library/blocks/post-title/style-rtl.css 100亿
build/block-library/blocks/post-title/style.css 100亿
build/block-library/blocks/preactatted/style-rtl.css 103亿
构建/块库/blocks/preformatted/style.css 103亿
build/block-library/blocks/pullquote/editor-rtl.css 135亿
build/block-library/blocks/pullquote/editor.css 135亿
build/block-library/blocks/pullquote/style-rtl.css 326亿
build/block-library/blocks/pullquote/style.css 325磅
build/block-library/blocks/pullquote/theme-rtl.css 167亿
构建/block-library/blocks/pullquote/theme.css 167亿
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122亿
build/block-library/blocks/query-pagination-numbers/editor.css 121亿
build/block-library/blocks/query-pagination/editor-rtl.css 221亿
build/block-library/blocks/query-pagination/editor.css 211亿
build/block-library/blocks/query-pagination/style-rtl.css 282亿
build/block-library/blocks/query-pagination/style.css 278亿
build/block-library/blocks/query-title/style-rtl.css 63亿
build/block-library/blocks/query-title/style.css 63亿
build/block-library/blocks/query/editor-rtl.css 439亿
build/block-library/blocks/query/editor.css 439亿
build/block-library/blocks/quote/style-rtl.css 213亿
build/block-library/blocks/quote/style.css 213亿
build/block-library/blocks/quote/theme-rtl.css 223亿
构建/block-library/blocks/quote/theme.css 226亿
build/block-library/blocks/read-more/style-rtl.css 132亿
build/block-library/blocks/read-more/style.css 132亿
build/block-library/blocks/rss/editor-rtl.css 202亿
build/block-library/blocks/rss/editor.css 204亿
构建/块库/blocks/rss/style-rtl.css 289亿
build/block-library/blocks/rss/style.css 288亿
build/block-library/blocks/search/editor-rtl.css 165亿
build/block-library/blocks/search/editor.css 165亿
build/block-library/blocks/search/style-rtl.css 409亿
build/block-library/blocks/search/style.css 406亿
构建/block-library/blocks/search/theme-rtl.css 114亿
构建/block-library/blocks/search/theme.css 114亿
build/block-library/blocks/seleparator/editor-rtl.css 146亿
build/block-library/blocks/seleparator/editor.css 146亿
build/block-library/blocks/seleparater/style-rtl.css 234亿
build/block-library/blocks/seleparater/style.css 234亿
build/block-library/blocks/seleparater/theme-rtl.css 194亿
build/block-library/blocks/seleparater/theme.css 194亿
构建/块库/blocks/shortcode/editor-rtl.css 464亿
build/block-library/blocks/shortcode/editor.css 464亿
build/block-library/blocks/site-logo/editor-rtl.css 488亿
build/block-library/blocks/site-logo/editor.css 488亿
build/block-library/blocks/site-logo/style-rtl.css 203亿
build/block-library/blocks/site-logo/style.css 203亿
build/block-library/blocks/site-tagline/editor-rtl.css 86亿
build/block-library/blocks/site-tagline/editor.css 86亿
build/block-library/blocks/site-title/editor-rtl.css 84亿
build/block-library/blocks/site-title/editor.css 84亿
build/block-library/blocks/social-link/editor-rtl.css 184亿
build/block-library/blocks/social-link/editor.css 184亿
build/block-library/blocks/social-links/editor-rtl.css 674亿
build/block-library/blocks/social-links/editor.css 673亿
build/block-library/blocks/social-links/style-rtl.css 1.4千字节
build/block-library/blocks/social-links/style.css 1.39千字节
build/block-library/blocks/spacer/editor-rtl.css 322亿
build/block-library/blocks/spacer/editor.css 322亿
build/block-library/blocks/spacer/style-rtl.css 48亿
build/block-library/blocks/spacer/style.css 48亿
build/block-library/blocks/table/editor-rtl.css 494磅
build/block-library/blocks/table/editor.css 494亿
build/block-library/blocks/table/style-rtl.css 611亿
build/block-library/blocks/table/style.css 609亿
build/block-library/blocks/table/theme-rtl.css 190亿
build/block-library/blocks/table/theme.css 190亿
构建/block-library/blocks/tag-cloud/style-rtl.css 239亿
build/block-library/blocks/tag-cloud/style.css 239亿
build/block-library/blocks/template-part/editor-rtl.css 235亿
build/block-library/blocks/template-part/editor.css 235亿
build/block-library/blocks/template-part/theme-rtl.css 101亿
build/block-library/blocks/template-part/theme.css 101亿
构建/块库/blocks/text列/editor-rtl.css 95亿
build/block-library/blocks/text-columns/editor.css 95亿
build/block-library/blocks/text-columns/style-rtl.css 166亿
build/block-library/blocks/text-columns/style.css 166亿
build/block-library/blocks/verse/style-rtl.css 87亿
build/block-library/blocks/verse/style.css 87亿
build/block-library/blocks/video/editor-rtl.css 561亿
build/block-library/blocks/video/editor.css 563亿
build/block-library/blocks/video/style-rtl.css 174亿
build/block-library/blocks/video/style.css 174亿
构建/block-library/blocks/video/theme-rtl.css 126亿
build/block-library/blocks/video/theme.css 126亿
build/block-library/common-rtl.css 1.02千字节
build/block-library/common.css 1.02千字节
build/block-library/editor-elements-rtl.css 75亿
build/block-library/editor-elements.css 75亿
build/block-library/editor-rtl.css 11千字节
build/block-library/editor.css 11千字节
构建/块-库/元素-rtl.css 54亿
build/block-library/elements.css 54亿
build/block-library/reset-rtl.css 478亿
build/block-library/reset.css 478亿
build/block-library/style-rtl.css 12.2千字节
build/block-library/style.css 12.2千字节
构建/块库/theme-rtl.css 719亿
构建/块-库/theme.css 722亿
build/block-serialization-default-parser/index.min.js 1.1千字节
build/block-serialization-specifi-parser/index.min.js 2.83千字节
build/blocks/index.min.js 49.6千字节
build/components/index.min.js 198千字节
build/components/style-rtl.css 11.4千字节
build/components/style.css 11.5千字节
构建/撰写/索引min.js 12.5千字节
构建/core-data/index.min.js 15.5千字节
构建/定制e-widgets/index.min.js 11.3千字节
构建/定制e-widgets/style-rtl.css 1.38千字节
构建/自定义widgets/style.css 1.38千字节
构建/数据控制/索引.min.js 653亿
build/data/index.min.js 8.08千巴
构建/日期/索引.min.js 32.1千字节
build/deprecated/index.min.js 507亿
构建/dom-ready/index.min.js 324亿
构建/dom/index.min.js 4.7千字节
构建/编辑导航/index.min.js 16千字节
构建/编辑导航/样式-rtl.css 3.99千字节
构建/编辑导航/样式.css 4千字节
构建/编辑-发布/分类-rtl.css 546亿
构建/编辑post/classic.css 547亿
build/edit-post/index.min.js 30.7千字节
构建/编辑-发布/样式-rtl.css 6.94千字节
构建/编辑-发布/样式.css 6.94千字节
build/edit-site/index.min.js 58千字节
构建/编辑site/style-rtl.css 8.36千字节
构建/编辑site/style.css 8.34千字节
build/edit-widgets/index.min.js 16.5千字节
build/edit-widgets/style-rtl.css 4.34千字节
build/edit-widgets/style.css 4.34千字节
build/editor/index.min.js 41.7千字节
构建/编辑器/样式-rtl.css 3.66千字节
构建/编辑器/样式.css 3.65千字节
构建/元素/索引min.js 4.68千字节
build/escape-html/index.min.js 537亿
build/format-library/index.min.js 6.76千字节
build/format-library/style-rtl.css 571亿
构建/格式库/样式.css 571亿
build/hooks/index.min.js 1.64千字节
build/html-entities/index.min.js 448亿
build/i18n/index.min.js版本 3.77千字节
构建/is-shallow-equal/index.min.js 527亿
构建/键盘快捷方式/index.min.js 1.78千字节
构建/list-reasable-blocks/index.min.js 1.74千字节
构建/list-rusable-blocks/style-rtl.css 835亿
build/list-rusable-blocks/style.css 835亿
build/media-utils/index.min.js 2.93千字节
build/notices/index.min.js 953亿
build/nux/index.min.js 2.05千字节
build/nux/style-rtl.css 732磅
build/nux/style.css 728亿
build/plugins/index.min.js 1.94千字节
构建/首选项持久性/index.min.js 2.22千字节
build/preferences/index.min.js 1.3千字节
build/primitives/index.min.js 933亿
build/priority-queue/index.min.js 1.58千字节
build/rect-i18n/index.min.js版本 696亿
build/react-refresh-entry/index.min.js 8.44千字节
build/react-refresh-runtime/index.min.js 7.31千字节
build/redux-routine/index.min.js 2.74千字节
构建/可重用块/index.min.js 2.21千字节
构建/可重用块/样式-rtl.css 256亿
构建/可重用块/样式.css 256亿
build/rich text/index.min.js版本 10.6千字节
build/server-side-render/index.min.js 1.61千字节
build/shortcode/index.min.js 1.53千字节
build/style-engine/index.min.js 1.45千字节
构建/token-list/index.min.js 644亿
构建/url/index.min.js 3.61千字节
build/vendors/react-dom.min.js 38.5千字节
build/vendors/react.min.js 4.34千字节
build/viewport/index.min.js 1.09千字节
build/warning/index.min.js 268亿
build/widgets/index.min.js 7.18千字节
构建/widgets/style-rtl.css 1.18千字节
build/widgets/style.css 1.19千字节
构建/wordcount/index.min.js 1.06千字节

压缩尺寸作用

复制链接
贡献者

@德拉加内斯库 德拉加内斯库 留下了评论

选择隐藏此评论的原因

将显示原因,以便向其他人描述此评论。了解更多信息.

这在OSX上似乎没有问题,所以我会在代码中为它添加一个排除项。

@阿勒克斯汀
复制链接
贡献者

@德拉加内斯库感谢您检查此内容,但我没有看到任何新的提交。你把零钱推到这里了吗?

//替换一些字符以匹配指示的键
//按修改键时的快捷方式。
if(event.shiftKey&&character.length===1){
key=key.replace('<',',');
复制链接
贡献者

选择隐藏此评论的原因

将显示原因,以便向其他人描述此评论。了解更多信息.

感谢您为此所做的工作。这是最近的衰退吗?这让我感到惊讶,因为这段代码似乎有一段时间基本上没有改变,而且我本应该会收到不少错误报告。

我认为这不是正确的解决方案,因为它假设用户的键盘有一个布局<,共享密钥。

例如,许多欧洲键盘布局(丹麦语、荷兰语、意大利语)都有;,共享密钥(https://en.wikipedia.org/wiki/List_of_QWERTY键盘语言变体).

我认为最好尝试从事件有效载荷中了解按下了哪个键(例如,它看起来像event.code===“逗号”)

复制链接
贡献者

选择隐藏此评论的原因

将显示原因,以便向其他人描述此评论。了解更多信息.

@塔尔丹这肯定是一个错误。例如,按ctrl+将通过地标移动,但ctrl+shift+不再有效。这种情况已经有一段时间了,所以我希望这次公关至少能告诉我们出了什么问题,以便进行更多的修复。

我不记得上一次这些在Windows上运行得很好的时候了。。。

@t-hamano公司
复制链接
贡献者 作者

谢谢你的评论,@塔尔丹!

事件.shiftKey&&
字符长度===1&&
事件代码==='逗号'
) {
复制链接
贡献者 作者

选择隐藏此评论的原因

将显示原因,以便向其他人描述此评论。了解更多信息.

我已经改变了流程,只替换某些键,这样就不会影响键盘布局。
我嵌套了if语句,以期将来替换其他键。
此外,如中所述这个评论,我排除了AppleOS。

复制链接
贡献者

@塔尔丹 塔尔丹 留下了评论

选择隐藏此评论的原因

将显示原因,以便向其他人描述此评论。了解更多信息.

对此进行了测试,并在Windows中解决了问题。

感觉我们需要一种可扩展的方式来为其他损坏的快捷方式(以及未来的快捷方式)推出此功能,但我认为这是一个好的开始。谢谢你的工作!

免费注册 在GitHub上加入此对话.已经有帐户了吗?登录以发表评论
标签
[Package]密钥 /包/密钥 [类型]Bug 现有功能无法按预期工作
项目
还没有
开发

成功合并此请求可能会解决这些问题。

还没有

4名参与者