Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

refactoring monitor code, support prometheus #1668

Merged
merged 2 commits into from Mar 11, 2020
Merged

refactoring monitor code, support prometheus #1668

merged 2 commits into from Mar 11, 2020

Conversation

fatedier
Copy link
Owner

@fatedier fatedier commented Feb 20, 2020 •
edited

Only care about first commit. Just remove vendor codes in second commit since we use go mod instead.

This was referenced Feb 20, 2020
Closed
Closed
@zyfdegh
Copy link

great job, nice code

kingjcy
kingjcy reviewed Feb 22, 2020
View reviewed changes
Copy link

@kingjcy kingjcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

LGFM

server/service.go
if cfg. EnablePrometheus {
modelmetrics. EnablePrometheus()
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Are these two interdependent? Think about using it alone?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

The current configuration parameters are not suitable. I have done so for the time being, which has little impact.

@fatedier fatedier mentioned this pull request Mar 11, 2020
Closed
@fatedier fatedier merged commit 495d999 into dev Mar 11, 2020
@fatedier fatedier deleted the new branch March 11, 2020 05:21
@oldthreefeng oldthreefeng mentioned this pull request Aug 10, 2020
Closed
@Becods Becods mentioned this pull request Sep 29, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@kingjcy kingjcy kingjcy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fatedier @zyfdegh @kingjcy