Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Allow to specify image dimensions/quality in API URLs to get the transformed image #11264

Merged
merged 13 commits into from
Aug 27, 2021
Merged

Allow to specify image dimensions/quality in API URLs to get the transformed image #11264

merged 13 commits into from
Aug 27, 2021

Conversation

damianlegawiec
Copy link
Member

eg.

 http://localhost:3000/products/3 -4-sleeve-t-shirt? include=images&image_transformation[size]=100x50&image_transformation[quality]=50

@viezly
Copy link

viezly bot commented Aug 18, 2021 •
edited
Loading

Changes preview:

👀 Review pull request on Viezly

@damianlegawiec damianlegawiec force-pushed the feature/api-request-image-dimensions branch from e18d398 to 6cfe2a3 Compare August 22, 2021 20:00
@tniezg tniezg self-assigned this Aug 23, 2021
damianlegawiec
damianlegawiec commented Aug 24, 2021
View reviewed changes
api/app/controllers/spree/api/v2/base_controller.rb Outdated Show resolved Hide resolved
api/spec/requests/spree/api/v2/storefront/products_spec.rb
@@ -668,5 +668,42 @@

it_behaves_like 'returns 404 HTTP status'
end

context 'with product image data' do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

@szymoniwacz we also need a similar test for taxon image

@damianlegawiec damianlegawiec force-pushed the feature/api-request-image-dimensions branch from 64f61ff to b58c08e Compare August 27, 2021 18:06
@damianlegawiec damianlegawiec marked this pull request as ready for review August 27, 2021 18:15
@damianlegawiec damianlegawiec merged commit 986812f into main Aug 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/api-request-image-dimensions branch August 27, 2021 19:16
@tniezg tniezg mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tniezg tniezg

@szymoniwacz szymoniwacz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damianlegawiec @tniezg @szymoniwacz