Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Corrected @since Order in Php Docs #310

Closed
wants to merge one commit into from
Closed

Corrected @since Order in Php Docs #310

wants to merge one commit into from

Conversation

shail-mehta
Copy link

renatonascalves
renatonascalves reviewed Jun 2, 2024
View reviewed changes
src/bp-core/admin/bp-core-admin-functions.php
@@ -220,9 +220,9 @@ function bp_core_add_admin_notice( $notice = '', $type = 'updated' ) {
* - that no WP page has multiple BP components associated with it.
* The administrator will be shown a notice for each check that fails.
*
* @global wpdb $wpdb WordPress database object.
Copy link
Member

@renatonascalves renatonascalves Jun 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

oh, had no idea it needed to be after. Good catch!

renatonascalves
renatonascalves reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

all looks good here.

dcavins pushed a commit to dcavins/buddypress-wp-svn that referenced this pull request Jun 4, 2024
PHPDoc: Correct placement of @since tags.
240a8e6 
 The `@since` tag should added before `@global`, `@param`, and `@return`. Props shailu25 Closes  buddypress/buddypress#310 See #9164 Fixes #9168 git-svn-id: http://buddypress.svn.wordpress.org/trunk @13896 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
@shail-mehta shail-mehta deleted the correct-since-order-in-php-doc branch August 3, 2024 07:15
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@renatonascalves renatonascalves renatonascalves left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shail-mehta @renatonascalves