Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Add different color for visited links. #128

Closed
StevenDufresne opened this issue Mar 28, 2024 · 6 comments · Fixed by #129
Closed

Add different color for visited links. #128

StevenDufresne opened this issue Mar 28, 2024 · 6 comments · Fixed by #129
Assignees
@adamwoodnz
Labels
[Component] Theme Templates, patterns, CSS

Comments

@StevenDufresne
Copy link
Contributor

Reported: https://meta.trac.wordpress.org/ticket/7529

The new theme doesn't have a color for visited links. I don't see it in the figma .

@WordPress/meta-design
@jasmussen
Copy link

Is a classic purple color sufficient? If yes, I'd go with this one: #7a00df

@fcoveram
Copy link

Agree with @jasmussen

@macmanx2
Copy link

That'll work, thanks!

@adamwoodnz adamwoodnz self-assigned this Apr 2, 2024
@adamwoodnz adamwoodnz added [Component] Theme Templates, patterns, CSS and removed [Status] Needs Design labels Apr 2, 2024
This was referenced Apr 2, 2024
Merged
Closed
@adamwoodnz
Copy link
Contributor

adamwoodnz commented Apr 2, 2024 •
edited
Loading

Adding this style to the parent does have wide ranging effects which will take some effort to override in undesirable places. See the screenshots on the PR . I think we should consider whether this is what we want across the network. An alternative could be only applying it only on the Forums where there has been a user request.

@jasmussen
Copy link

I responded on the PR, that IMO the visited style should not be applied to navigation links (footer/header), CTAs (anything on the homepage) and other "evergreen" links (hero sections, callouts, headings).

Is it possible to scope it only to sections that feature blue links on white text as a starting point? IMO that could mean applying it in blanket style across the entire Learn category as a starting point (Learn, Forums, Developer Resources, Documentation), and then expand from there as we learn how to best apply it?

@fcoveram
Copy link

Agree with @jasmussen . The plan proposed also sounds good to me if doable.

bazza pushed a commit to WordPress/wordpress.org that referenced this issue Apr 29, 2024
wporg-support-2024: Prevent caching of parent theme styles
ead582a 
 Use filemtime for version See #248 See WordPress/wporg-parent-2021#128 git-svn-id: https://meta.svn.wordpress.org/sites/trunk @13608 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
[Component] Theme Templates, patterns, CSS
Projects
@adamwoodnz's WIP
Status: Done
WordPress.org Redesign
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the color of visited links to purple WordPress/wporg-parent-2021
6 participants
@ryelle @fcoveram @adamwoodnz @jasmussen @StevenDufresne @macmanx2