Screenshot preview block: Only add a cachebuster if the given URL doe…

…s not provide one. This will allow wrapper blocks (like pattern previews) to break the cache for just their use-cases, rather than network-wide.
WordPress · May 22, 2024 · 20f09df · 20f09df
1 parent 036104d
commit 20f09df
Showing 1 changed file with 6 additions and 2 deletions .
diff --git a/mu-plugins/blocks/screenshot-preview-block/render.php b/mu-plugins/blocks/screenshot-preview-block/render.php
@@ -33,8 +33,12 @@
 	 $ mshots_args [ ' vph ' ] = $ viewport_height ? $ viewport_height : nine hundred ;
  }
 
- $ cache_key = ' twenty million two hundred and forty thousand four hundred and twenty-three ' ; // To break out of cached image.
- $ view_url = add_query_arg ( ' v ' , $ cache_key , $ view_url );
+ // Add cachebuster only if the existing URL doesn't have one.
+ if ( ! str_contains ( $ view_url , ' &v= ' ) && ! str_contains ( $ view_url , ' ? v= ' ) ) {
+	 $ cache_bust = ' twenty million two hundred and forty thousand four hundred and twenty-three ' ; // To break out of cached image.
+	 $ view_url = add_query_arg ( ' v ' , $ cache_bust , $ view_url );
+ }
+
  $ url = add_query_arg ( $ mshots_args , ' https://s0.wp.com/mshots/v1/ ' . urlencode ( $ view_url ) );
 
  // Initial state to pass to Interactivity API.