Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local navigation to the About page #385

Closed
ndiego opened this issue Jan 23, 2024 · 4 comments · Fixed by #387
Closed

Add local navigation to the About page #385

ndiego opened this issue Jan 23, 2024 · 4 comments · Fixed by #387
Assignees
Labels
[Component] Theme Templates, patterns, CSS

Comments

 @ndiego
Copy link
Member

We have begun introducing local navigation on a number of new site redesigns. Showcase and the new Developer Resources sites are good examples.

The About page has a number of important sub-pages, but they are very hard to find. You have to scroll to the very bottom of the page to see the links.

 image

While there may be merit to redesigning the entire page, I propose we take an interim step and simply add local navigation to the About page. It could look something like the local navigation on the Developer Blog that features dropdowns for the respective categories.

 image

It's worth noting that the internal About pages already have this local navigation.

 image

What do you think @fcoveram and @jasmussen ?

 @ndiego ndiego added the [Status] Needs Design Feedback Feedback is needed on an existing or new component label Jan 23, 2024
 @fcoveram
Copy link

One of the improvements proposed in wporg-mu-plugins#535 for the global navigation is based on the same idea, initially suggested by @ryelle . Here is the video attached in the ticket mention for a quick view.

Desktop.local.nav.v22-compressed.mp4

I would like us to evaluate the benefits of the proposal and its implementation in case we decide to do it.

 @ryelle
Copy link
Contributor

There's also some discussion on #255 , though that predates the latest global nav + local nav designs that are in place (and should probably be closed in favor of this issue).

I think we could add a local nav bar to /about/ fairly easily, with a nav menu & dropdowns, since it already works on the Developer Blog.

As far as I can tell, the main change in the above global nav proposal is the breadcrumbs area, but we could leave that iteration for later and just make the nav change on /about/ .

 @fcoveram
Copy link

That sounds great to me @ryelle

Copy link

Iterative improvements are certainly welcome.

 @ryelle ryelle added [Component] Theme Templates, patterns, CSS and removed [Status] Needs Design Feedback Feedback is needed on an existing or new component labels Feb 1, 2024
 @ryelle ryelle self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants