Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Add docblock to PostTitle and PostTitleRaw component #61740

Merged
merged 6 commits into from
May 21, 2024
Merged

Add docblock to PostTitle and PostTitleRaw component #61740

merged 6 commits into from
May 21, 2024

Conversation

sanjucta
Copy link
Contributor

What?

Addresses one item in #60358

Why?

Adding documentation to existing editor components can help with any of the following:

  • encourages knowledge sharing and quicker onboarding for future devs
  • supports maintenance and troubleshooting

How?

Testing Instructions

This PR justs adds a JSDoc comment to the PostTitle component and populates the README with the new documents generated by running npm run docs:build

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

 Co-authored-by: sanjucta < sanjucta@git.wordpress.org > Co-authored-by: colorful-tones < colorful-tones@git.wordpress.org >

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook .

@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sanjucta ! In case you missed it, we'd love to have you join us in our Slack community .

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 16, 2024
@colorful-tones colorful-tones self-assigned this May 16, 2024
@colorful-tones colorful-tones added the [Type] Developer Documentation Documentation for developers label May 17, 2024
@colorful-tones colorful-tones changed the title Add docblock to PostTitle component Add docblock to PostTitle and PostTitleRaw component May 17, 2024
@colorful-tones colorful-tones mentioned this pull request May 17, 2024
Open
82 tasks
@colorful-tones colorful-tones merged commit dd4e2dd into WordPress : trunk May 21, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.5 milestone May 21, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
@sanjucta @colorful-tones @carstingaxion
Add docblock to PostTitle and PostTitleRaw component ( WordPress#61740 )
0f9558f 
 * Add docblock to PostTitle component * Refine PostTitle component JSDocs * Add PostTitleRaw component JSDocs * Add usePostTitle JSDocs * Add usePostTitleFocus JSDocs * Auto-generate editor docs for PostTitle updates --------- Co-authored-by: Damon Cook < damonacook@gmail.com >
Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@colorful-tones colorful-tones colorful-tones approved these changes

@alexstine alexstine Awaiting requested review from alexstine alexstine is a code owner

Assignees

@colorful-tones colorful-tones

Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 18.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanjucta @colorful-tones