You signed in with another tab or window.Reloadto refresh your session.You signed out in another tab or window.Reloadto refresh your session.You switched accounts on another tab or window.Reloadto refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding theprops-botlabel.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Seems fine. But now I'm wondering if we should apply this at the component level :) Ideally wrapping in button labels should be kept to a minimum, but when it does occur shouldn't italwaysbepretty?
Seems fine. But now I'm wondering if we should apply this at the component level :) Ideally wrapping in button labels should be kept to a minimum, but when it does occur shouldn't italwaysbepretty?
cc @WordPress/gutenberg-components.
I'd prefer to keep this outside of the components territory, as it could break (or inadvertently change) existing buttons. Maybe we could reconsider if the browser support improves. Also, some folks might preferbalance.
The appearance of these buttons is very inconsistent:
Imo they should all respect the same rules, and likely be fixed in a single PR.
I have a small preference for truncating to one line; the full value can be viewed by clicking the button, or in the case of the date button by inokving the tooltip on hover/focus. Visually it looks neater:
If truncating to a single line is too aggressive, then perhaps to 3 or 4 lines so we can avoid this:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
