-
Notifications You must be signed in to change notification settings -
Fork 4k
New issue
Remove PHPUnit and Composer packages
#50408
Remove PHPUnit and Composer packages
#50408
Conversation
ObliviousHarmony
commented May 5, 2023
•
edited
Loading
edited
What?
Why?
phpunit -
WordPress Core has stopped using the container -
It does not provide an ARM image
-
composer -
It uses whatever version of PHP is packaged with the image when it is downloaded, not the version of PHP you have installed. This can lead to it installing incompatible PHP dependencies in certain circumstances.
-
How?
Testing Instructions
-
Run npx wp-env destroy . -
Run npx wp-env start --update . -
Run npx wp-env run cli bash . -
Check out composer and phpunit and confirm they run. -
Do the same in the wordpress , tests-wordpress , and tests-cli containers. -
Run npm run format:php and confirm that it works as expected. -
Run npm run lint:php and confirm that it works as expected.
|
||
|
||
|
||
|
||
|
||
|
||
|
Choose a reason for hiding this comment
|
|||
|
|||
|
|||
|
|||
|
|||
|
Choose a reason for hiding this comment
This commit removes these containers because they don't work the way you'd expect them to anymore. It also adds Composer and PHPUnit globally to all of the containers so that people can support the workflows these containers used to.
Co-authored-by: Noah Allen < noahtallen@gmail.com >
Choose a reason for hiding this comment
|
Choose a reason for hiding this comment
-
We don't really document the phpunit & composer options already. -
Both containers have been broken recently. -
At least one of the containers has been broken for a while on M* macs. -
It's confusing to have multiple containers that aren't much different from each other.