Size Change: +1.26 kB (0%)

Total Size: 1.19 MB

_{compressed-size-action}

Thanks for the PR! This seems like it could be a cool feature, but it also adds a great deal of complexity to a sidebar that is currently complex.

That doesn't mean we can't make it work, but it does mean that it needs a good and solid sidebar component control design before we can move on it. We will get there, but I'll ask your patience because it might not be this week!

CC: @jameskoster @ItsJonQ

That doesn't mean we can't make it work, but it does mean that it needs a good and solid sidebar component control design before we can move on it

Yeah, agree. I did a pretty-simple buttons group, but the idea is to be able to switch it for another component easily. I tried to get involved with some ideas around this component but not lucky so far.

@retrofox , I'm glad to work on this feature. In case you hadn't see it, I wanted to point out the related concept in #20193 . Something like that, while probably a good bit more effort to implement, could sidestep the concern about a complicating the sidebar. Plenty to work out though even beside the implementation since that concept only seems to detail the "custom" scenario and it's not shown how that might switch from "cover" or "contain".

@retrofox , I'm glad to work on this feature. In case you hadn't see it, I wanted to point out the related concept in #20193 .

Thanks. Yes, I saw it :-)

Something like that, while probably a good bit more effort to implement, could sidestep the concern about a complicating the sidebar.

What's not clear to me is the UI. should the block change its inner content with an Editing background tool ? Providing a save button that allows going back to the regular state?

Plenty to work out though even beside the implementation since that concept only seems to detail the "custom" scenario and it's not shown how that might switch from "cover" or "contain".

we can add a preview button to switch quickly between background edition mode and regular mode

What's not clear to me is the UI. should the block change its inner content with an Editing background tool ?

In that issue it is mentioned #20193 (comment) :

... would focus just on the background of the block (fading all the layered blocks and their controls away)

But do they fade away completely? It may be desirable to adjust the background in relation to the inner blocks but because it will vary responsively, perhaps just fading them away completely is better. It does seem clear they should not be selectable though.

Providing a save button that allows going back to the regular state?

I think that's the checkmark here:

But it'd probably be better to do like the Image block currently implements for cropping and supply “Apply” and “Cancel” buttons.

BTW, my original comment here was supposed to say “I'm glad to see work on this feature”, to express appreciation for your work on this. (And while I would like to work on the implementation I'm not sure when I'll find the time).

This hasn't been worked on in a number of years! I'm going to close it out as a result and encourage you to open a new PR that's in sync with the current codebase at this point. There's some great efforts currently under way to improve background image support too over the last couple of releases if you wanted to get involved there: #54336