Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Image component (continued) #18040

Closed
wants to merge twenty-five commits into from
Closed

Image component (continued) #18040

wants to merge twenty-five commits into from

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Oct 21, 2019 •
edited

Description

This PR adds a didCancel flag to prevent an asynchronous function call from an unmounted functional component ( useEffect hook), which was causing console errors in tests in the original PR: #17104 .

Related gutenberg-mobile PR : wordpress-mobile/gutenberg-mobile#1472

koke and others added twenty-four commits August 20, 2019 13:00
@koke
Initial implementation of Image component
86f3931
@koke
Allow forwarding refs to Image component
9f2fc1a
@koke
Use new Image component in Gallery
119f794
@koke
Use Image component for image block
bc0382e
@koke
Use Image component for media-text block
three million one hundred and twenty-two thousand six hundred and eighty-nine
@koke
First (untested) native implementation of Image component
776380b
@koke
Fix native tests
d81a130
@koke
Merge branch 'master' into add/image-component
1a5e92e
@koke
Use new Image component for image block instead of ImageBackground
70650e0
@koke
Merge branch 'master' into add/image-component
a739474
@koke
Merge branch 'master' into add/image-component
f8c3fe3
@koke
Merge branch 'add/image-component' of github.com:WordPress/gutenberg …
2a4799e 
 …into add/image-component
@koke
Use aspectRatio approach for responsive Image component
b47140e
@koke
Add missing import
2cfecd4
@koke
Use snapshots for Image tests
816e3ed
@koke
Fix image import in tests
191fb5a
@koke
Don't assume an initial aspect ratio
eight million two hundred and sixty-one thousand six hundred and fifty-five
@koke
Better syntax for undefined initial value
6cd9e13
@koke
Update tests
b146418
@koke
Merge branch 'master' into add/image-component
373c507
@koke
Lint fixes
45ce1fc
@mkevins
Merge branch 'master' into add/image-component
012c308
@mkevins
Merge branch 'master' into add/image-component
9d009de
@mkevins
Use isMounted flag in hook to prevent callback console errors in tests
8ba1ea8
@mkevins mkevins added the [Status] In Progress Tracking issues with work in progress label Oct 21, 2019
@mkevins mkevins mentioned this pull request Oct 21, 2019
Closed
@mkevins mkevins changed the title Add/image component matt Image component (continued) Oct 21, 2019
Base automatically changed from master to trunk March 1, 2021 15:42
@annezazu
Copy link
Contributor

This hasn't been worked on in a number of years! I'm going to close it out as a result and encourage you to open a new PR that's in sync with the current codebase at this point.

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

@artemiomorales artemiomorales Awaiting requested review from artemiomorales artemiomorales will be requested when the pull request is marked ready for review artemiomorales is a code owner

@michalczaplinski michalczaplinski Awaiting requested review from michalczaplinski michalczaplinski will be requested when the pull request is marked ready for review michalczaplinski is a code owner

@geriux geriux Awaiting requested review from geriux geriux will be requested when the pull request is marked ready for review geriux is a code owner

Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkevins @annezazu @koke