Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Missing Focus Ring on Pattern Inserter from Sidebar #60211

Closed
jeryj opened this issue Mar 26, 2024 · 3 comments · Fixed by #60881
Closed

Missing Focus Ring on Pattern Inserter from Sidebar #60211

jeryj opened this issue Mar 26, 2024 · 3 comments · Fixed by #60881
Assignees
@jeryj
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@jeryj
Copy link
Contributor

Some patterns do not have a focus style. In this image, focus was moved to the "Standard" pattern (the tooltip is visible), but the focus ring is not present. All patterns should have some sort of focus indicator.
@jeryj jeryj self-assigned this Mar 26, 2024
@jeryj jeryj added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Mar 26, 2024
@getdave
Copy link
Contributor

This is "In Progress" but there is no linked PR.

This was referenced Apr 22, 2024
Closed
Merged
@jeryj
Copy link
Contributor Author

@getdave Thanks for the catch. There's a PR ready for review at #60881

@getdave
Copy link
Contributor

No problem. I just wondered if there a PR I could review 😄

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Assignees

@jeryj jeryj

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
Automattic team Ignite's project board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pattern preview focus styles WordPress/gutenberg
2 participants
@getdave @jeryj