Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Custom Palette colors applied inconsistently and not globally #36979

Closed
annezazu opened this issue Nov 29, 2021 · 2 comments
Closed
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

 @annezazu
Copy link
Contributor

Description

As part of the eleventh call for testing for the FSE Outreach program, an issue was found with using custom color palettes:

custom palette colours could not be applied globally, e.g. to all the headings, though the theme defined colours did work when applied globally. The custom palette colours did however work when applied to individual blocks.

When testing this further, I found that they don't seem to work at all, either globally or for individual blocks.

Step-by-step reproduction instructions

  1. Open up the Appearance > Editor (beta)
  2. Open up global styles.
  3. Go to the Colors section.
  4. Add a custom color to the color palette.
  5. Try applying them to various parts of your site (background, text, etc). Notice no changes.
  6. Try selecting an individual block like the Post Title block and apply a custom color palette. Notice either no change (Post title block doesn't change) or some blocks do change (Site Title does change)

Screenshots, screen recording, code snippet

custom.color.palette.mov

Environment info

  • WordPress 5.9-alpha-52262
  • Gutenberg 12.01
  • TT1 blocks
  • Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

 @annezazu annezazu added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 29, 2021
 @annezazu annezazu changed the title Global Styles: Custom Palette colors applied very inconsistently and not globally Global Styles: Custom Palette colors applied inconsistently and not globally Nov 29, 2021
 @glendaviesnz
Copy link
Contributor

glendaviesnz commented Dec 16, 2021

@annezazu are you still seeing this on beta 3? I just gave it a try and custom colours seem to apply as expected:

 custom-colors

The above is in the content/footer area of the TwentyTwentyTwo theme - in the header area, some of the colour changes don't apply as they appear to be overridden by individual block settings in the template.

 @annezazu
Copy link
Contributor Author

Huzzah! I cannot replicate anymore either with beta 3. Thanks for following up. Closing this out :)

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants