Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Fix badge circle #231

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix badge circle #231

merged 2 commits into from
Oct 18, 2023

Conversation

BenjaminZekavica
Copy link
Member

@BenjaminZekavica BenjaminZekavica commented Oct 16, 2023 •
edited
Loading

Reference: https://wordpress.org/five-for-the-future/pledge/benjamin-zekavica-projects/
I fixed the Circle CSS for displaying the badges and spacing on the single page.

Before:

before

After:

after

@BenjaminZekavica
Copy link
Member Author

Can anyone check the CI? Thanks :)

@StevenDufresne
Copy link
Contributor

Can anyone check the CI? Thanks :)

Unrelated to this PR. 👍

@BenjaminZekavica
Copy link
Member Author

@StevenDufresne Perfect, thank you :) Do you can approve this PR?

@iandunn
Copy link
Member

Hey Benjamin, thanks for the PR 👋 🏻 I'm not sure what problem this is solving, though. Can you explain that more?

@BenjaminZekavica
Copy link
Member Author

BenjaminZekavica commented Oct 18, 2023 •
edited
Loading

@iandunn You're welcome :) I fixed the circle, because if the text on the right side is bigger, than the circle looks like an egg :D

I added and tested the new css Code and it works very well.

Bildschirmfoto 2023-10-18 um 21 07 03

@iandunn
Copy link
Member

Ah, I sse it now 👍 🏻

iandunn
iandunn approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

LGTM 👍 🏻

@iandunn iandunn merged commit 2ee6d9d into WordPress : production Oct 18, 2023
1 of 2 checks passed
@iandunn
Copy link
Member

It's the end of my day, so I'm going to wait until tomorrow to sync/deploy this.

@BenjaminZekavica
Copy link
Member Author

It's the end of my day, so I'm going to wait until tomorrow to sync/deploy this.

Thank you so much :)

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers

@iandunn iandunn iandunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminZekavica @StevenDufresne @iandunn