Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account
Jump to bottom

Allow extenders to remove additional format types. #204

Open
wants to merge one commit into
base: trunk
Choose a base branch
from
Open

Allow extenders to remove additional format types. #204

wants to merge one commit into from

Conversation

dd32
Copy link
Member

Instead of rolling our own plugin to extend the editor, it would be useful if the list of unsupported format types was defined through the PHP Configuration of Blocks Everywhere.

For example; See https://meta.trac.wordpress.org/changeset/13561 for how this PR is being used currently.

bazza pushed a commit to WordPress/wordpress.org that referenced this pull request Apr 18, 2024
@dd32
Support Forums: Remove additional format options that are not needed …
cecb441 
 …in the support Forums. See Automattic/blocks-everywhere#204 . See #7599. git-svn-id: https://meta.svn.wordpress.org/sites/trunk @13561 74240141-8908-4e6f-9713-ba540dce6ec7
@dd32
Copy link
Member Author

An alternative would be to expose the allowedFormats option somewhere I guess too.

dd32
dd32 commented Apr 19, 2024
View reviewed changes
classes/class-handler.php
Comment on lines +334 to +337
'unregisterFormatType' => [
'core/text-color',
'core/image',
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more .

Open to better names for this option too, I just named it the same as the G function it was calling, there's probably a better naming format..

Sign up for free to join this conversation on GitHub . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dd32