#61112
closed
defect (bug)
( fixed )
Avoid re-constructing `WP_Theme_JSON` object from raw theme_json, instead use `WP_Theme_JSON` object inside `WP_Theme_JSON_data`
|
|
|
|
---|---|---|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Description
<? php $theme_json = apply_filters ( 'wp_theme_json_data_default' , new WP_Theme_JSON_Data ( $config , 'default' ) ); $config = $theme_json -> get_data (); static :: $core = new WP_Theme_JSON ( $config , 'default' );
<? php public function __construct ( $data = array (), $origin = 'theme' ) { $this -> origin = $origin ; $this -> theme_json = new WP_Theme_JSON ( $data , $this -> origin ); }
Change History (34)
This ticket was mentioned in PR #6271 on WordPress/wordpress-develop by @thekt12 .
5 months ago
#1
| |
---|---|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
---|---|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
#2
@
5 months ago
-
Milestone changed from Awaiting Review to six point six -
Owner set to thekt12 -
Status changed from new to assigned
@oandregal commented on PR #6271 :
5 months ago
#3
@thekt12 commented on PR #6271 :
5 months ago
#4
Oh, by the way. It'd be nice if this change would have been done first in the Gutenberg codebase. The value that provides is immense to all of us, including easier synchronization and quick feedback from Gutenberg users if we've missed something. I have nothing against merging it in wordpress-develop first, though I'd kindly ask that the authors port the same PR to Gutenberg. Until we figure out something better, this is what we collectively have and need to care for.
@oandregal commented on PR #6271 :
5 months ago
#5
This ticket was mentioned in Slack in #core-performance by joemcgill. View the logs .
5 months ago
This ticket was mentioned in Slack in #core-performance by thekt12. View the logs .
4 months ago
This ticket was mentioned in Slack in #core-performance by mukeshpanchal27. View the logs .
4 months ago
#9
@
4 months ago
-
Keywords commit added
@joemcgill commented on PR #6271 :
4 months ago
#11
#12
@
4 months ago
-
Keywords has-patch commit removed -
Resolution fixed deleted -
Status changed from closed to reopened
#13
@
4 months ago
#14
@
4 months ago
#15
@
4 months ago
Fatal error: Uncaught Error: Call to undefined method WP_Theme_JSON_Data_Gutenberg::get_theme_json() in wp-includes/class-wp-theme-json-resolver.php on line 257 Call stack: WP_Theme_JSON_Resolver::get_theme_data() wp-includes/class-wp-theme-json-resolver.php:598 WP_Theme_JSON_Resolver::get_merged_data() wp-includes/global-styles-and-settings.php:182 wp_get_global_stylesheet() wp-includes/block-editor.php:511
#16
@
4 months ago
This ticket was mentioned in PR #6626 on WordPress/wordpress-develop by @joemcgill .
4 months ago
#17
-
Keywords has-patch added
#18
@
4 months ago
#19
@
4 months ago
#20
@
4 months ago
#21
@
4 months ago
@joemcgill commented on PR #6626 :
4 months ago
#22
This ticket was mentioned in Slack in #core-performance by mukeshpanchal27. View the logs .
4 months ago
#24
@
4 months ago
-
Keywords has-testing-info needs-testing added
#25
@
4 months ago
@joemcgill commented on PR #6626 :
4 months ago
#26
#27
@
4 months ago
This ticket was mentioned in Slack in #core-performance by joemcgill. View the logs .
3 months ago
@pbearne commented on PR #6626 :
3 months ago
#29
This ticket was mentioned in Slack in #core-performance by mukeshpanchal27. View the logs .
3 months ago
@oandregal commented on PR #6626 :
3 months ago
#31
@joemcgill commented on PR #6626 :
3 months ago
#33