#56699
closed
enhancement
( fixed )
Remove IE specific checks from default themes
|
|
|
|
---|---|---|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Description
-
stylesheets targeting specific versions of IE -
an HTML5 shiv targeting IE 6-9, Safari 4.x, and Firefox 3.x.
-
All versions of IE have been considered "dead" (no official support or updates for at least 24 months) for some time now. -
Firefox 3.x has 0.014% market share . -
Safari 4.x has 0.000% market share .
-
Twenty Eleven -
Twenty Twelve -
Twenty Thirteen -
Twenty Fourteen -
Twenty Fifteen -
Twenty Sixteen -
Twenty Seventeen
Attachments (3)
Change History (51)
#1
@
21 months ago
-
Keywords needs-patch added -
Milestone changed from Awaiting Review to six point two
#2
@
21 months ago
-
Continue to enqueue those scripts/styles in the default theme without specifying a source. This will make the script/style handle an alias, and the scripts/styles will continue to load. -
Just remove the handles entirely. The scripts and styles outside of the default themes will no longer be loaded. But this could be OK because they are targeting old browsers anyway.
#3
follow-up:
↓ 7
@
21 months ago
-
Maintains the handles, source references, etc. -
Keeps all IE-specific files within the theme package to avoid errors. -
Requires site admins to opt in to loading them in the theme.
This ticket was mentioned in PR #3474 on WordPress/wordpress-develop by @neychok .
21 months ago
#4
-
Keywords has-patch added; needs-patch removed
#5
@
21 months ago
-
Completely remove all IE code -
Just change wp_enqueue_ to wp_register_ where possible and leave the rest, like in the case with TwentyEleven -
Remove all IE code except where we have wp_enqueue_ that's going to be changed to wp_register_ instead.
This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs .
20 months ago
#7
in reply to: ↑ 3
@
18 months ago
-
Keywords needs-patch added; has-patch removed
Option 3: Switch the
wp_enqueue_ functions to
wp_register_ for any IE-related files.
Maintains the handles, source references, etc. Keeps all IE-specific files within the theme package to avoid errors. Requires site admins to opt in to loading them in the theme.
#8
@
17 months ago
-
Milestone changed from six point two to Future Release
-
If we only make the changes to Twenty Eleven's header.php template file, that should minimize what breaks. If some people really want to maintain support in their sites, then they could do that with a different header template. -
We could be somewhat selective with the proposed CSS revisions. WordPress admin has not supported older IE versions for years, so editor-style.css should not need to accommodate them. Also, the gradients' solid color fallbacks would make their absence very minor. And the negative padding values probably never worked ( #46771 ). -
Removing the other IE-related CSS could reduce the front-end stylesheets by about 1 KB. The difference is small enough to consider keeping those for possible continued use in child themes (which I expect would be very rare). -
To avoid any four hundred and four errors, please _ keep a file _ at js/html5.js . The script is not particularly large at about 2.4 KB, so it could stay intact. If it is worth removing from the package, however, its contents could be replaced with a single-line comment such as "This theme does not support old versions of Microsoft Internet Explorer anymore. "
#9
@
15 months ago
-
Keywords needs-testing added -
Milestone changed from Future Release to six point three
This ticket was mentioned in Slack in #slackhelp by ramsesdelr. View the logs .
14 months ago
This ticket was mentioned in Slack in #core by oglekler. View the logs .
13 months ago
#12
@
13 months ago
This ticket was mentioned in PR #4642 on WordPress/wordpress-develop by @metodiew .
12 months ago
#13
-
Keywords has-patch added; needs-patch removed
@metodiew commented on PR #4642 :
12 months ago
#14
This ticket was mentioned in PR #4644 on WordPress/wordpress-develop by @metodiew .
12 months ago
#15
This ticket was mentioned in PR #4658 on WordPress/wordpress-develop by @metodiew .
12 months ago
#16
This ticket was mentioned in PR #4659 on WordPress/wordpress-develop by @neychok .
12 months ago
#17
@neychok commented on PR #3474 :
12 months ago
#18
This ticket was mentioned in PR #4660 on WordPress/wordpress-develop by @neychok .
12 months ago
#19
This ticket was mentioned in PR #4661 on WordPress/wordpress-develop by @neychok .
12 months ago
#20
This ticket was mentioned in PR #4662 on WordPress/wordpress-develop by @neychok .
12 months ago
#21
#22
@
12 months ago
#23
@
12 months ago
-
Keywords needs-dev-note added -
Owner set to audrasjb -
Status changed from new to reviewing
@audrasjb commented on PR #4662 :
12 months ago
#25
@audrasjb commented on PR #4661 :
12 months ago
#27
@audrasjb commented on PR #4660 :
12 months ago
#29
#30
@
12 months ago
If replacing the code in html5.js is good, then all the IE-specific CSS could be removed. It would be highly difficult for someone to restore old IE support, if anyone feels the need, though I do not expect people would go through extra effort for that.
#31
@
12 months ago
-
Keep the conditional code from Twenty Eleven/Twelve/Thirteen/Fourteen, most likely with their own header.php file in a child theme. (If they already have the template, this part would be completed.) -
Enqueue any registered stylesheet(s) and/or script that had been enqueued earlier. (Theoretically, sites could have added the styles and script separate from the parent, either by printing directly or by enqueuing another stylesheet with the IE styles as a dependency.)
#32
@
12 months ago
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs .
12 months ago
#34
@
12 months ago
-
Resolution set to fixed -
Status changed from reviewing to closed
#36
@
12 months ago
#40
@
12 months ago
-
Keywords needs-testing removed
This ticket was mentioned in Slack in #core by audrasjb. View the logs .
12 months ago
#43
@
12 months ago
#45
@
12 months ago
#46
@
12 months ago
#47
@
12 months ago
-
Using a custom header.php template that nearly matches the parent template (Twenty Thirteen's has a valuable edit but the others simply remove the XFN link). -
Calling scripts and styles as dependencies of other resources. -
Enqueuing or printing the IE scripts and styles with the parent theme's URLs. -
Trying to restore support by enqueuing the scripts and styles and/or including IE conditional classes.