Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceandprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign into your account
Jump to bottom

[5.1] Convert mod_version to service provider #42814

Merged
merged 16 commits intofrom
Feb 26, 2024
Merged

[5.1] Convert mod_version to service provider #42814

merged 16 commits intofrom
Feb 26, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the version administrator module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_version published
  2. You should see module output

mod_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commentedFeb 15, 2024

I have tested this item ✅ successfully on366e884

This comment was created with theJ!Tracker Applicationatissues.joomla.org/tracker/joomla-cms/42814.

@ceford
Copy link
Contributor

ceford commentedFeb 20, 2024

I have tested this item ✅ successfully on6be703c

This comment was created with theJ!Tracker Applicationatissues.joomla.org/tracker/joomla-cms/42814.

@richard67
Copy link
Member

@fgswCould you test this PR again? Thanks in advance.

@fgsw
Copy link

fgsw commentedFeb 20, 2024

@fgswCould you test this PR again? Thanks in advance.

No re-test. Reason:comment.

@richard67
Copy link
Member

@fgswI've restored the result from your previous test in the issue tracker since the changes after that were code style only.

@richard67
Copy link
Member

RTC

This comment was created with theJ!Tracker Applicationatissues.joomla.org/tracker/joomla-cms/42814.

@joomla-cms-bot joomla-cms-botaddedtheRTC This Pull Request is Ready To CommitlabelFeb 20, 2024
@LadySolveig LadySolveigadded this to theJoomla! 5.1.0milestoneFeb 24, 2024
@LadySolveig LadySolveigmerged commitdacda5cinto joomla:5.1-dev Feb 26, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you@joomlawebyfor your work and your endurance!
I am of course also very very happy and grateful for the tests@fgsw @cefordand the cs-fix@richard67

@joomla-cms-bot joomla-cms-botremovedtheRTC This Pull Request is Ready To CommitlabelFeb 26, 2024
@richard67 richard67mentioned this pull request Mar 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub.Already have an account?Sign in to comment
Reviewers

@richard67 richard67 richard67 left review comments

@sandewt sandewt sandewt left review comments

Assignees
No one assigned
Labels
PR-5.1-dev
Projects
None yet
Milestone
Joomla! 5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@joomlaweby @fgsw @ceford @richard67 @LadySolveig @sandewt @joomla-cms-bot