You signed in with another tab or window.Reloadto refresh your session.You signed out in another tab or window.Reloadto refresh your session.You switched accounts on another tab or window.Reloadto refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Complete the code that truncates long descriptions. As seen in administrator/components/com_modules/tmpl/module/edit.php administrator/components/com_plugins/tmpl/plugin/edit.php administrator/components/com_scheduler/tmpl/task/edit.php But only partially seen in administrator/components/com_templates/tmpl/style/edit.php
each element that used "JGLOBAL_SHOW_FULL_DESCRIPTION", have a parent element with onclick attribute...
Testing Instructions
Update the descrption of the cassiopeia template inlanguage\en-GB\tpl_cassiopeia.iniso that it is over 500 characters long.
Actual result BEFORE applying this Pull Request
The entire description is displayed
Expected result AFTER applying this Pull Request
The description is truncated and a new tab is present with the full description
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: <link
No documentation changes for manual.joomla.org needed
Comment
Alternatively the partial support for this truncation functionality can be removed from com_templates
now it is better to choose one code style in these four file...
onclick="document.getElementById('myTab').activateTab(document.getElementById('description'));" or onclick="document.querySelector('[aria-controls=description]').click();"
I've restored the previous human test result in the issue tracker as the 2 commits after the test were only a code style change and a clean branch update.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
